Reland: Wire native CSS parsing for fontVariant#55881
Closed
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Closed
Reland: Wire native CSS parsing for fontVariant#55881NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: ## Reland No changes. This was on the same stack as a bugged change to `aspectRatio` parsing, which caused S627731, and this was backed out as well. ## Original Gate `processFontVariant` behind `enableNativeCSSParsing()`. When the flag is on, CSS font-variant strings like `"small-caps oldstyle-nums"` are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS. Also removes `react_native_expect(false)` hard error on unknown font variant values, replacing it with a graceful skip. Changelog: [Internal] Reviewed By: javache Differential Revision: D95021048
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95021048. |
|
This pull request has been merged in 2f6c744. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in 2f6c744 When will my fix make it into a release? | How to file a pick request? |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: facebook#55881 ## Reland No changes. This was on the same stack as D95032494 which was backed out due to bug. ## Original Gate `processFontVariant` behind `enableNativeCSSParsing()`. When the flag is on, CSS font-variant strings like `"small-caps oldstyle-nums"` are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS. Also removes `react_native_expect(false)` hard error on unknown font variant values, replacing it with a graceful skip. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D95021048 fbshipit-source-id: e75ce199565c7de3b883a95c61e5e534c2018cba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reland
No changes. This was on the same stack as a bugged change to
aspectRatioparsing, which caused S627731, and this was backed out as well.Original
Gate
processFontVariantbehindenableNativeCSSParsing(). When the flag is on, CSS font-variant strings like"small-caps oldstyle-nums"are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS.Also removes
react_native_expect(false)hard error on unknown font variant values, replacing it with a graceful skip.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D95021048